Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the asv benchmarks #1687

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Check the asv benchmarks #1687

wants to merge 2 commits into from

Conversation

aragilar
Copy link
Member

@aragilar aragilar commented Oct 3, 2020

This adds asv check to (quoting command) "Import and check benchmark suite, but do not run benchmarks." I think this should mean we're checking for syntax errors and such, but not actually running the benchmarks (which might be a bit slow...). I've put this on travis just in case it does take some time, but there's nothing special about the python or HDF5 version used.

@takluyver
Copy link
Member

Failing because it can't find Cython when trying to build. I think Cython gets installed in the tox environment where asv is run, but not in the environment asv creates to install h5py. However, it looks like asv disables pip's build isolation, so it's not getting another level of environment isolation there.

Possibly relevant: airspeed-velocity/asv#903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants