Fix for zero length collective IO - rebased #1634
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collective IO where one rank attempts to read or write a zero length slice causes the a hang in an underlying collective call. This fix ensures that all ranks participate in any collective IO operation even if some operations are on zero length slices. This also includes some basic unit testing for collective IO that tests for this problem.
|
It seems the tests are broadcasting, not sure why? |
|
We implement some special casing which in this case pre-broadcasts the 0D data to 1D. I'd suggest that the broadcasting check should happen before that - it's an implementation detail, and it's still logically broadcasting if we do it with numpy before passing data to HDF5. |
|
I just want to add a "+1" for this since it's something we've been working around for many years (#412 !!). I haven't poked around in the h5py internals before, but I might be able to help out with a little direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #965, rebased version of #1206. As there were a bunch of changes which were adding something, then removing it, I've squashed eveything as it made it much easier to rebase.