New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the c-side constructor of numpy's dtype to expose the typobj attibute #1439
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1439 +/- ##
==========================================
- Coverage 84.94% 84.82% -0.12%
==========================================
Files 17 17
Lines 2105 2128 +23
==========================================
+ Hits 1788 1805 +17
- Misses 317 323 +6
Continue to review full report at Codecov.
|
Close/reopen to rerun tests. |
I can't reproduce the error either. :-/ |
Apparently @s-sajid-ali can't reproduce this either. @kif do you think the change is an improvement anyway, or should we close it? |
This change is probably an improvement as it uses the CAPI |
Using the C-api is not always a good move. In this case, apparently it changes little. I am pretty agnostic. if @s-sajid-ali cannot reproduce the bug, I would probably drop the PR as it solves no issue. |
We can leave it open for a month or so in case this bug pops-out again then. |
I'm inclined to agree with 'if it ain't broke, don't fix it'. Good idea to leave it open and obvious for a bit in case someone else can reproduce it, though. |
This still seems like a positive change to me |
close #1436
@s-sajid-ali could you test this branch ?