Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fedibird emoji_reaction support #1737

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

potproject
Copy link
Contributor

@potproject potproject commented May 24, 2023

This PR supports the emoji_reactions used in fedibird(https://github.com/fedibird/mastodon)

Issue

#1736

Fedibird Source

https://github.com/fedibird/mastodon/blob/main/app/serializers/rest/emoji_reaction_serializer.rb

Tips

[Breaking Change] Entity.Reaction.accounts is being changed to Entity.Reaction.account_ids. This is a destructive change, but since there was no place where Entity.Reaction.accounts was used, we believe the impact will be minimal.

@potproject potproject requested a review from h3poteto as a code owner May 24, 2023 09:07
@h3poteto
Copy link
Owner

but since there was no place where Entity.Reaction.accounts was used, we believe the impact will be minimal.

Even if you don't use this, it doesn't mean that all users don't use it. So it is still breaking change.
That means I can't merge this casually.

@h3poteto
Copy link
Owner

And I wonder if we should support instance-specific features.

@potproject
Copy link
Contributor Author

Even if you don't use this, it doesn't mean that all users don't use it. So it is still breaking change.
That means I can't merge this casually.

Sorry, I thought this value was completely unused, but it was used by Pleroma. I am sure you are right that it cannot be merged casually. This code has been removed.

And I wonder if we should support instance-specific features.

ok.I agree. If you don't want to merge this Issue and PR, you can close it.

@h3poteto
Copy link
Owner

h3poteto commented Jun 6, 2023

@potproject Can you please rebase this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants