Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize cleanup jobs #192

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Optimize cleanup jobs #192

wants to merge 4 commits into from

Conversation

ilyesAj
Copy link
Contributor

@ilyesAj ilyesAj commented Nov 30, 2022 •
edited

I noticed that cleanup is done in two steps:
as-is

  • cleanup pods related to the job
  • cleanup the job as an orphan

proposal

The goal of the PR is let k8s cleanup the job and all the related pods accordingly,

  • i added propagationPolicy: foreground that guarantees the deletion of the job with all related pods . (possible values)
  • i deleted uneeded role deletecollection uneeded anymore

@ilyesAj
Copy link
Contributor Author

ilyesAj commented Nov 30, 2022

i'm not sure if i need to add something on the unit test side

@h3poteto
Copy link
Owner

Can you please add a test to check the job is deleted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h3poteto h3poteto Awaiting requested review from h3poteto h3poteto is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ilyesAj @h3poteto