Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bubble Up regexp Error For BodyMatchString #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

midnightconman
Copy link

This should make fixing regex pattern issues easier... to bubble up an error like this:

https://play.golang.org/p/dubZiQ-HCN0

@h2non
Copy link
Owner

h2non commented Jan 10, 2019

Tests are failing. Can you take a look?

@midnightconman
Copy link
Author

Sorry this took so long, I missed this PR 😺

I am not sure this test failure is related to my changes, what do you think?

--- FAIL: TestJSONSchemaInvalid (0.00s)
	<autogenerated>:1: 
		json_schema_test.go:67: should be == 
		 	have: (bool) false
			want: (bool) true

I don't see any error handling in the code base around the function I changed... can you take a look and let me know if you can find any additional info?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants