Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pom.xml related to CVE-2024-1597 #4007

Merged
merged 6 commits into from Feb 25, 2024
Merged

Update pom.xml related to CVE-2024-1597 #4007

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
47c4fbc
Update pom.xml related to CVE-2024-1597
manticore-projects Feb 22, 2024
209e7a5
Update Build.java
manticore-projects Feb 22, 2024
2e471b5
Update Build.java
manticore-projects Feb 22, 2024
4991cb2
Update Build.java
manticore-projects Feb 25, 2024
a1c26ac
Update pom.xml
manticore-projects Feb 25, 2024
679b136
Update Build.java
manticore-projects Feb 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion h2/pom.xml
View file
Open in desktop
Expand Up @@ -44,7 +44,7 @@
<lucene.version>9.7.0</lucene.version>
<osgi.version>5.0.0</osgi.version>
<osgi.jdbc.version>1.1.0</osgi.jdbc.version>
<pgjdbc.version>42.5.4</pgjdbc.version>
<pgjdbc.version>[42.5.5,)</pgjdbc.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use exact versions here to make sure that attempts to launch unit tests from Maven will use configuration at least similar to the main configuration.

PgJDBC isn't included into distribution of H2 and H2 doesn't depend on it, so neither we nor users of H2 are affected by security issues in libraries used only in our unit tests, alerts about them can be ignored.

Please, try latest 42.7.2 instead of this old 42.5.*, it will be more reasonable to upgrade to some modern version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback, I have adopted 42.7.2 as advised.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PgJDBC isn't included into distribution of H2 and H2 doesn't depend on it, so neither we nor users of H2 are affected by security issues in libraries used only in our unit tests, alerts about them can be ignored.

From what I can see, the Maven build file (which is not effective) is defining the dependency and so any security scanner will think that H2 was affected by this vulnerability. Unfortunately even a wrong security report is still a report and that's why I have tried to fix it.

<javax.servlet.version>4.0.1</javax.servlet.version>
<jakarta.servlet.version>5.0.0</jakarta.servlet.version>
<slf4j.version>2.0.7</slf4j.version>
Expand Down
4 changes: 2 additions & 2 deletions h2/src/tools/org/h2/build/Build.java
View file
Open in desktop
Expand Up @@ -55,9 +55,9 @@ public class Build extends BuildBase {

private static final String OSGI_JDBC_VERSION = "1.1.0";

private static final String PGJDBC_VERSION = "42.5.4";
private static final String PGJDBC_VERSION = "42.5.5";

private static final String PGJDBC_HASH = "015015a54f15e340a9a8a6a2c5457429cb1176b8";
private static final String PGJDBC_HASH = "6592900e2bd48195c91bc3cecc688a51951d02f2";

private static final String JAVAX_SERVLET_VERSION = "4.0.1";

Expand Down