fix: CSV empty String to Number conversion #3786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSV Number Columns can have empty Cells, e.g. '' which still need to be translated to a Number Column Type. So instead of creating a new Number from the empty String (which will fail), a NULL Number must be returned. fixes h2database#3785
|
Thank you for your contribution! Please send a licence statement as described here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSV Number Columns can have empty Cells, e.g.
''which still need to be translated to a Number Column Type. So instead of creating a new Number from the empty String (which will fail), a NULL Number must be returned.Example CSV:
Shall return
'102.22', nullinstead of'102.22', ''or else conversion toDECIMAL(12.2)will fail.fixes #3785