Fix NPE when closing cloned JdbcConnection #3402
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closing a cloned JdbcConnection (by calling the copy constructor) results in an NPE:
This is because the clone nulls out the watcher field of the cloned object, which I believe is by design:
h2database/h2/src/main/org/h2/jdbc/JdbcConnection.java
Line 154 in 465399f
Circumvented with a simple null check which I propose as a small fix.