CpuId reader trait and serialize feature fix #140
Conversation
gz
commented
Mar 1, 2023
gz
commented
- original discussion here More granular display features #138
- fixed Serialization issue #87
For new() and default() methodes.
Makes sure signatures taking CpuId remain unchanged `fn take_cpuid(cpuid: CpuId) -> CpuId` and don't need to add generics.
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
==========================================
+ Coverage 39.34% 41.46% +2.12%
==========================================
Files 4 4
Lines 4072 3849 -223
==========================================
- Hits 1602 1596 -6
+ Misses 2470 2253 -217
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
This looks good to me! |
|
Thanks for taking a look! I think the remaining thing I'm not sure about yet is if the default argument with NativeCpuIdReader is a good idea (if done solely for x86). Maybe I'll write some code examples later on the mac and see how weird it gets. |
|
Ok so better late than never... I'm going to merge this now and release v11. I did remove the default generic argument again, because even without it I don't think it's too bad for migration for users to v11. |
|
Thanks for merging this in! Can you please push a release to crates.io as well, so we can update our dependencies? |
|
Just released v11 |
