Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zstd-sys: Don't use target* cfg in build.rs to fix Windows cross-compile #176

Commits on Nov 21, 2022

  1. zstd-sys: Don't use target* cfg in build.rs to fix Windows cross-…

    …compile
    
    This issue got exposed with [CC upgrading to 1.0.77] and now detecting
    the `.S` file extension to pass on to `ml64.exe` (MASM) on Windows;
    we don't have that on our cross-compiling (from Linux to Windows) CI
    setup, hence uncovered that this build script was using the _`target_os`
    flag from the host_ in the build script to make a decision on _what to
    compile for the target_.
    
    [CC upgrading to 1.0.77]: rust-lang/cc-rs@1.0.76...1.0.77
    MarijnS95 committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    6a2495c View commit details
    Browse the repository at this point in the history