Fix case where the user info are added dispite empty

[gmponos]

Check failing test here , guzzle/guzzle#2327

[Tobion]

This is not according to rfc 3986

Applications should not render as clear text any data
after the first colon (":") character found within a userinfo
subcomponent unless the data after the colon is the empty string
(indicating no password)

[gmponos]

I am not sure if I follow. At the moment if I do something like this:

        $uri = (new Uri('http://example.org/path'))->withUserInfo('', '');
        echo (string)$uri;

It will output http://:@example.org/path

Is this correct?

[Tobion]

http://:@example.org/path is a valid URI and browsers do accept it as well. It's basic auth with empty username and no password. There is not much use to it but it's valid.
Why not call withUserInfo('', null) or just withUserInfo('')? That would be the right thing to do as the default for password is null which means, no password.

[gmponos]

Thank you.. I did not knew about this. I pushed a fixed to Guzzle client at the PR I mentioned above..

[sagikazarmark]

@Tobion this still seems to be a regression to me (as mentioned in #290), but I'm inclined to leave it as is if there is no real case where this can cause problems (except in the breaking tests).