Add typehints and return types to private functions and constructors. #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmponos
commented
Dec 6, 2018
gmponos
commented
Dec 6, 2018
gmponos
commented
Dec 6, 2018
gmponos
force-pushed
the
add_return_typehints
branch
from
9283035
to
4fecfd9
Compare
Tobion
reviewed
Dec 28, 2018
Tobion
reviewed
Dec 28, 2018
Tobion
reviewed
Dec 28, 2018
Tobion
reviewed
Dec 28, 2018
Tobion
reviewed
Dec 28, 2018
Tobion
reviewed
Dec 28, 2018
Tobion
requested changes
Dec 28, 2018
|
@Tobion thank you very much for the review... before we proceed with current PR maybe we should have a look on this PR #250 ? It is related to this discussion... after that if someone could merge master branch to |
|
@Tobion can you check if the applied changes fulfill your requests? |
Tobion
reviewed
Jun 6, 2019
Tobion
reviewed
Jun 6, 2019
Tobion
reviewed
Jun 6, 2019
Tobion
reviewed
Jun 6, 2019
Tobion
reviewed
Jun 9, 2019
Tobion
force-pushed
the
add_return_typehints
branch
from
3a7d0aa
to
47d2d61
Compare
Tobion
force-pushed
the
add_return_typehints
branch
from
47d2d61
to
eb6f13a
Compare
|
@gmponos Thanks for working on this. I rebased and finished the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process of adding return types and typehinting the code can be a long one.
That's why I thought about starting with the easy ones. So I added return types to private functions and constructors.