Fix trim headers values #197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prisis
reviewed
Apr 13, 2018
| @@ -177,7 +177,7 @@ private function setHeaders(array $headers) | |||
| private function trimHeaderValues(array $values) | |||
| { | |||
| return array_map(function ($value) { | |||
| return trim($value, " \t"); | |||
| return trim(strval($value), " \t"); | |||
|
This error can only happen if you use strict types which is not enabled in this repo.
You are using a fork apparently. |
|
I see that you are using |
|
Fixed in #272 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Type error: trim() expects parameter 1 to be string, integer given" at /vendor/nyholm/psr7/src/MessageTrait.php line 216