Add compatibility with PHPUnit 9.3 #118
Conversation
|
Will conflict with #113. |
|
@GrahamCampbell I have reworked the PR hoping this will make the merge easier |
|
Could you please rebase this PR? |
|
I started working on PHP8 another ago. I see that that PR is using PHPUnit 9.3.10 with the symfony phpunit bridge. Have a look at #122. What are the pros/cons between that approach? |
| @@ -1,11 +1,10 @@ | |||
| <?php | |||
|
|
|||
| namespace GuzzleHttp\Tests\Promise; | |||
| namespace GuzzleHttp\Promise\Tests; | |||
|
|
||
| class TestCase extends PHPUnitTestCase | ||
| { | ||
| public function setExpectedException($exception, $message = null, $code = null) |
There was a problem hiding this comment.
This is actually the job of Symfony PHPUnit bridge.
| @@ -403,7 +397,7 @@ public function testCanCatchAndYieldOtherException() | |||
| $promise->otherwise(function ($value) use (&$result) { $result = $value; }); | |||
| P\Utils::queue()->run(); | |||
| $this->assertTrue(P\Is::rejected($promise)); | |||
| $this->assertContains('foo', $result->getMessage()); | |||
| $this->assertTrue(strpos($result->getMessage(), 'foo') !== false, "'" . $result->getMessage() . " does not contain 'foo'"); | |||
When I have originally open this PR I wanted to keep it as minimal as possible. |
|
Yeah, I appreciate that. This morning when I started with this library I had no plans of creating PHP8 support. Thank you for you work. |
This is a required step to build the project with PHP8.