Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Curl: Improve Accept-Encoding comment #3215

Open
wants to merge 2 commits into
base: 7.8
Choose a base branch
from
Open

Curl: Improve Accept-Encoding comment #3215

wants to merge 2 commits into from

Commits on Apr 13, 2024

  1. Curl: Improve Accept-Encoding comment 

    guzzle@1d46cec
tried to improve the comment but the new content implies an empty header
will be sent.

That is not the case. Quoting from <https://curl.se/libcurl/c/CURLOPT_HTTPHEADER.html>:

    If you add a header with no content as in 'Accept:'
    (no data on the right side of the colon),
    the internally used header is disabled/removed.

Let’s clarify the point is removing the header to get the default '*'
<https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept-Encoding#sect2>:

    *: Matches any content encoding not already listed in the header.
    This is the default value if the header is not present.
    This directive does not suggest that any algorithm is supported
    but indicates that no preference is expressed.

As that was probably intended by the original change that introduced this:
guzzle@1a9ad6b
    @jtojnar
    jtojnar committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    c7b61bf View commit details
    Browse the repository at this point in the history

  2. [Docs] Clarify Accept-Encoding not being sent by default

    @jtojnar
    jtojnar committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    1a91bce View commit details
    Browse the repository at this point in the history