Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass int to &$still_running of curl_multi_exec #2991

Merged
merged 2 commits into from Mar 7, 2022
Merged

Pass int to &$still_running of curl_multi_exec #2991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1a360b
[CurlMultiHandler] Pass `int` to `&$still_running` of `curl_multi_exec`
ruudk Mar 3, 2022
91e7ac4
Remove ignored error
ruudk Mar 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions phpstan-baseline.neon
View file
Open in desktop
Expand Up @@ -105,11 +105,6 @@ parameters:
count: 1
path: src/Handler/CurlMultiHandler.php

-
message: "#^Property GuzzleHttp\\\\Handler\\\\CurlMultiHandler\\:\\:\\$active has unknown class CurlMultiHandle as its type\\.$#"
count: 1
path: src/Handler/CurlMultiHandler.php

-
message: "#^Return typehint of method GuzzleHttp\\\\Handler\\\\CurlMultiHandler\\:\\:__get\\(\\) has invalid type CurlMultiHandle\\.$#"
count: 1
Expand Down
4 changes: 2 additions & 2 deletions src/Handler/CurlMultiHandler.php
View file
Open in desktop
Expand Up @@ -32,9 +32,9 @@ class CurlMultiHandler
private $selectTimeout;

/**
* @var resource|\CurlMultiHandle|null the currently executing resource in `curl_multi_exec`.
* @var int Will be higher than 0 when `curl_multi_exec` is still running.
*/
private $active;
private $active = 0;

/**
* @var array Request entry handles, indexed by handle id in `addRequest`.
Expand Down