Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stricter treatment of types in SetCookie #2945

Merged
merged 2 commits into from Oct 18, 2021
Merged

Stricter treatment of types in SetCookie #2945

merged 2 commits into from Oct 18, 2021

Conversation

GrahamCampbell
Copy link
Member

No breaking changes to the public interface. Just some corrections, and making sure internal types are what we expect.

@GrahamCampbell GrahamCampbell mentioned this pull request Oct 18, 2021
Merged
Nyholm
Nyholm approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank yu

@Nyholm Nyholm merged commit 70d32b9 into master Oct 18, 2021
@GrahamCampbell GrahamCampbell deleted the set-cookie-types branch October 18, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GrahamCampbell @Nyholm