Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw InvalidArgumentException when an incorrect headers array is provided #2942

Merged
merged 2 commits into from Oct 17, 2021
Merged

Throw InvalidArgumentException when an incorrect headers array is provided #2942

merged 2 commits into from Oct 17, 2021

Commits on Oct 13, 2021

  1. Throw InvalidArgumentException when an incorrect headers array is… 

    … provided

As discussed in PR guzzle#2916 after it was merged an `InvalidArgumentException` is
more fitting, as passing an invalid `headers` array is a clear programming
error that needs to be fixed and not caught.

This is consistent with the validation of the other options, e.g. when using
`multipart` and `form_params` at the same time.

see guzzle#2916
see a2b8dd1
    @TimWolla
    TimWolla committed Oct 13, 2021
    Copy the full SHA
    1668251 View commit details
    Browse the repository at this point in the history

  2. Remove obsolete import in Client.php / ClientTest.php

    @TimWolla
    TimWolla committed Oct 13, 2021
    Copy the full SHA
    62ca561 View commit details
    Browse the repository at this point in the history