Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PHP 8.1 #2929

Merged
merged 1 commit into from Sep 5, 2021
Merged

Support PHP 8.1 #2929

merged 1 commit into from Sep 5, 2021

Conversation

GrahamCampbell
Copy link
Member

No description provided.

Nyholm
Nyholm approved these changes Sep 5, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thank you!

@Nyholm Nyholm merged commit 815dae7 into master Sep 5, 2021
@GrahamCampbell GrahamCampbell deleted the php-81 branch September 5, 2021 19:12
@driesvints
Copy link

Hey @GrahamCampbell @Nyholm. Can we get these changes tagged? Thanks!

@GrahamCampbell
Copy link
Member Author

Waiting on a tag on the psr7 library, first. Still a PR over there that needs to be merged.

@driesvints
Copy link

Which PR?

@Nyholm
Copy link
Member

Nyholm commented Oct 7, 2021

We will prepare a new minor release. I dont see anything blocking anymore

@GrahamCampbell
Copy link
Member Author

"just" need to write a change log. :P

@mingww64 mingww64 mentioned this pull request Jan 18, 2022
Closed
@wouter-toppy
Copy link

@Nyholm can we merge the changes also in Guzzle 6.x?

src/Handler/MockHandler.php.

PHP Fatal error:  Uncaught Symfony\Component\ErrorHandler\Error\FatalError: Error: During inheritance of Countable: Uncaught Behat\Testwork\Call\Exception\CallErrorException: 8192: Return type of GuzzleHttp\Handler\MockHandler::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /app/vendor/guzzlehttp/guzzle/src/Handler/MockHandler.php line 173

We have our WMS still at Guzzle6 6.5.8
But we are almost ready to go to PHP8.1.

But upgrading to guzzle7 is not possilble at the moment, given we are waiting on several third party repos to implement 7 as well.
(like swagger-api/swagger-codegen#11123)

wouter-toppy added a commit to wouter-toppy/guzzle that referenced this pull request Jul 26, 2022
@wouter-toppy
Mock Handler for PHP8.1
b194aca 
See guzzle#2929
@wouter-toppy wouter-toppy mentioned this pull request Jul 26, 2022
Closed
@GrahamCampbell
Copy link
Member Author

No. Guzzle 6 does not support PHP 8.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GrahamCampbell @driesvints @Nyholm @wouter-toppy