Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in SetCookieTest #2896

Closed
wants to merge 2 commits into from
Closed

Fixed typo in SetCookieTest #2896

wants to merge 2 commits into from

Conversation

GrahamCampbell
Copy link
Member

Closes #2894.

@Nyholm
Copy link
Member

Nyholm commented May 31, 2021

Oops. It seams like a few tests depended on this.

@GrahamCampbell GrahamCampbell marked this pull request as draft May 31, 2021 08:35
@GrahamCampbell
Copy link
Member Author

Hmm. These tests seem bad. Unix timestamps are not allowed: https://datatracker.ietf.org/doc/html/rfc7231#section-7.1.1.1.

@stale
Copy link

stale bot commented Sep 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 2 weeks if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale No activity for a long time label Sep 28, 2021
@GrahamCampbell GrahamCampbell reopened this Oct 7, 2021
@stale stale bot removed the lifecycle/stale No activity for a long time label Oct 7, 2021
@GrahamCampbell GrahamCampbell deleted the fix-typo branch October 17, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo or PHP voodoo magic?
2 participants