Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robust handling of responses with invalid headers #2872

Merged
merged 2 commits into from Mar 21, 2021
Merged

Robust handling of responses with invalid headers #2872

merged 2 commits into from Mar 21, 2021

Conversation

GrahamCampbell
Copy link
Member

Thanks to @TimWolla for raising the issue.

@GrahamCampbell @TimWolla
Robust handling of responses with invalid headers
55c4ef4 
Co-Authored-By: Tim Düsterhus <209270+TimWolla@users.noreply.github.com>
Nyholm
Nyholm requested changes Mar 21, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick look.

I think this is alright.
Well done

src/Handler/HeaderProcessor.php Outdated Show resolved Hide resolved
src/Handler/HeaderProcessor.php Outdated Show resolved Hide resolved
src/Handler/StreamHandler.php Outdated Show resolved Hide resolved
Nyholm
Nyholm approved these changes Mar 21, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm merged commit f5aa695 into guzzle:master Mar 21, 2021
@GrahamCampbell GrahamCampbell deleted the robust-header-processing branch March 21, 2021 17:43
@GrahamCampbell GrahamCampbell added this to the 7.3.0 milestone Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimWolla TimWolla TimWolla approved these changes

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GrahamCampbell @TimWolla @Nyholm