Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on PHP8 #2789

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Test on PHP8 #2789

merged 1 commit into from
Oct 1, 2020

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Sep 30, 2020

This will replace #2714

@Nyholm Nyholm force-pushed the php8 branch 2 times, most recently from 4c7a00d to 74d6a30 Compare October 1, 2020 05:55
@Nyholm Nyholm added this to the 7.2.0 milestone Oct 1, 2020
composer.json Show resolved Hide resolved
@GrahamCampbell
Copy link
Member

GrahamCampbell commented Oct 1, 2020

Should we bring #2715 in to this PR (and change this PR's title to "Support PHP 8")?

@Nyholm
Copy link
Member Author

Nyholm commented Oct 1, 2020

Should we bring #2715 in to this PR (and change this PR's title to "Support PHP 8")?

I did for fun, and the tests passes. But I want to give @Ayesh a chance to finish their PR and we can merge them separately.

@GrahamCampbell
Copy link
Member

Can you cherry-pick his work and update the baseline yourself?

@Nyholm
Copy link
Member Author

Nyholm commented Oct 1, 2020

PR #2715 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants