New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid "functions" from dependencies #2712
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 27, 2020
GrahamCampbell
changed the title
[7.1] Avoid "functions" from dependencies
Avoid "functions" from dependencies
Sep 19, 2020
Closed
Nyholm
reviewed
Sep 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these changes looks good.
Thank you.
The Promises package and the PSR7 package is now tagged. |
Nyholm
approved these changes
Sep 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work.
Thank you
20 tasks
andrewminion-luminfire
pushed a commit
to macbookandrew/hubspot-api-php
that referenced
this pull request
Nov 3, 2021
Result of guzzle/guzzle#2712 Fixes HubSpot#73 and HubSpot/hubspot-php#363
dallasread
added a commit
to dnsimple/dnsimple-php
that referenced
this pull request
Nov 19, 2021
9 tasks
BrandonSurowiec
added a commit
to BrandonSurowiec/salesforce-laravel-oauth2-rest
that referenced
this pull request
Sep 23, 2023
Replace with the new `GuzzleHttp\Psr7\Utils::` static methods: guzzle/guzzle#2712
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to avoid the use of functions provided by our dependencies. This means using their new Utils classes, and bumping their minimum versions (
guzzlehttp/promises:^1.4
;guzzlehttp/psr7:^1.7
). Note that similar changes were already implemented for Guzzle 7.0 itself, but not its dependencies, which we are going to address now, for Guzzle 7.1.TODO:
guzzlehttp/promises
changes (Extracted functions to static methods promises#113)guzzlehttp/psr7
changes (Extracted functions to static methods psr7#345)composer.json
with^1.4
and^1.7
guzzlehttp/promises
1.4.0 and remove@dev
guzzlehttp/psr7
1.7.0 and remove@dev
Mappings:
GuzzleHttp\Promise\queue
GuzzleHttp\Promise\Utils::queue
GuzzleHttp\Promise\task
GuzzleHttp\Promise\Utils::task
GuzzleHttp\Promise\promise_for
GuzzleHttp\Promise\Create::promiseFor
GuzzleHttp\Promise\rejection_for
GuzzleHttp\Promise\Create::rejectionFor
GuzzleHttp\Promise\exception_for
GuzzleHttp\Promise\Create::exceptionFor
GuzzleHttp\Promise\iter_for
GuzzleHttp\Promise\Create::iterFor
GuzzleHttp\Promise\inspect
GuzzleHttp\Promise\Utils::inspect
GuzzleHttp\Promise\inspect_all
GuzzleHttp\Promise\Utils::inspectAll
GuzzleHttp\Promise\unwrap
GuzzleHttp\Promise\Utils::unwrap
GuzzleHttp\Promise\all
GuzzleHttp\Promise\Utils::all
GuzzleHttp\Promise\some
GuzzleHttp\Promise\Utils::some
GuzzleHttp\Promise\any
GuzzleHttp\Promise\Utils::any
GuzzleHttp\Promise\settle
GuzzleHttp\Promise\Utils::settle
GuzzleHttp\Promise\each
GuzzleHttp\Promise\Each::of
GuzzleHttp\Promise\each_limit
GuzzleHttp\Promise\Each::ofLimit
GuzzleHttp\Promise\each_limit_all
GuzzleHttp\Promise\Each::ofLimitAll
!GuzzleHttp\Promise\is_fulfilled
GuzzleHttp\Promise\Is::pending
GuzzleHttp\Promise\is_fulfilled
GuzzleHttp\Promise\Is::fulfilled
GuzzleHttp\Promise\is_rejected
GuzzleHttp\Promise\Is::rejected
GuzzleHttp\Promise\is_settled
GuzzleHttp\Promise\Is::settled
GuzzleHttp\Promise\coroutine
GuzzleHttp\Promise\Coroutine::of
GuzzleHttp\Psr7\str
GuzzleHttp\Psr7\Message::toString
GuzzleHttp\Psr7\uri_for
GuzzleHttp\Psr7\Utils::uriFor
GuzzleHttp\Psr7\stream_for
GuzzleHttp\Psr7\Utils::streamFor
GuzzleHttp\Psr7\parse_header
GuzzleHttp\Psr7\Header::parse
GuzzleHttp\Psr7\normalize_header
GuzzleHttp\Psr7\Header::normalize
GuzzleHttp\Psr7\modify_request
GuzzleHttp\Psr7\Utils::modifyRequest
GuzzleHttp\Psr7\rewind_body
GuzzleHttp\Psr7\Message::rewindBody
GuzzleHttp\Psr7\try_fopen
GuzzleHttp\Psr7\Utils::tryFopen
GuzzleHttp\Psr7\copy_to_string
GuzzleHttp\Psr7\Utils::copyToString
GuzzleHttp\Psr7\copy_to_stream
GuzzleHttp\Psr7\Utils::copyToStream
GuzzleHttp\Psr7\hash
GuzzleHttp\Psr7\Utils::hash
GuzzleHttp\Psr7\readline
GuzzleHttp\Psr7\Utils::readLine
GuzzleHttp\Psr7\parse_request
GuzzleHttp\Psr7\Message::parseRequest
GuzzleHttp\Psr7\parse_response
GuzzleHttp\Psr7\Message::parseResponse
GuzzleHttp\Psr7\parse_query
GuzzleHttp\Psr7\Query::parse
GuzzleHttp\Psr7\build_query
GuzzleHttp\Psr7\Query::build
GuzzleHttp\Psr7\mimetype_from_filename
GuzzleHttp\Psr7\MimeType::fromFilename
GuzzleHttp\Psr7\mimetype_from_extension
GuzzleHttp\Psr7\MimeType::fromExtension
GuzzleHttp\Psr7\_parse_message
GuzzleHttp\Psr7\Message::parseMessage
GuzzleHttp\Psr7\_parse_request_uri
GuzzleHttp\Psr7\Message::parseRequestUri
GuzzleHttp\Psr7\get_message_body_summary
GuzzleHttp\Psr7\Message::bodySummary
GuzzleHttp\Psr7\_caseless_remove
GuzzleHttp\Psr7\Utils::caselessRemove
Closes #2740.