Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small docblock fix. #2624

Closed
wants to merge 1 commit into from
Closed

Small docblock fix. #2624

wants to merge 1 commit into from

Conversation

shehi
Copy link

@shehi shehi commented Apr 22, 2020

No description provided.

@shehi
Copy link
Author

shehi commented Apr 22, 2020

Apparently PHPStan configuration doesn't fit this v6 of this package anymore?

@GrahamCampbell
Copy link
Member

Apparently PHPStan configuration doesn't fit this v6 of this package anymore?

The first error was actually directly caused by your PR. The second was caused by the upgrade of phpstan from .18 to .19. Please just re-generate the baseline file with your PR.

@shehi
Copy link
Author

shehi commented Apr 23, 2020

The first error was actually directly caused by your PR.

Not really, coz that specific exception is dynamic one (please check it's source). It is Throwable wherever Throwable is supported:

<?php
namespace GuzzleHttp\Exception;

use Throwable;

if (interface_exists(Throwable::class)) {
    interface GuzzleException extends Throwable
    {
    }
} else {
    /**
     * @method string getMessage()
     * @method \Throwable|null getPrevious()
     * @method mixed getCode()
     * @method string getFile()
     * @method int getLine()
     * @method array getTrace()
     * @method string getTraceAsString()
     */
    interface GuzzleException
    {
    }
}

I guess for this reason you guys got rid of this check in master branch?

re-generate baseline file

What does this mean?

@GrahamCampbell
Copy link
Member

Not really, coz that specific exception is dynamic one (please check it's source).

If you revert your changes, you will see the warning go away...

@GrahamCampbell
Copy link
Member

Evidence that I am correct is within the CI run of #2626.

@shehi shehi closed this Apr 24, 2020
@shehi
Copy link
Author

shehi commented Apr 24, 2020

Thank you, that's enough for me :)

@GrahamCampbell
Copy link
Member

This PR is still valid though, just the baseline file needs correcting. The current phpdoc references a class/interface that doesn't exist.

@GrahamCampbell
Copy link
Member

The fact that it doesn't extend throwable on all systems goes away on later versions of Guzzle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants