Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.1] Deprecate Utils::defaultCaBundle #2562

Merged
merged 1 commit into from
Jun 27, 2020
Merged

[7.1] Deprecate Utils::defaultCaBundle #2562

merged 1 commit into from
Jun 27, 2020

Conversation

GrahamCampbell
Copy link
Member

Requires #2561 to be merged first. Is a follow up to #2560.

@gmponos
Copy link
Member

gmponos commented Jan 19, 2020 •
edited

If we removed the usages of defaultCaBundle by merging #2560 why should we deprecate a function that it is not tagged? Do I miss something?

@gmponos gmponos added this to the 7.1.0 milestone Jan 19, 2020
@GrahamCampbell
Copy link
Member Author

Because the function might be still used by people outside of the guzzle core code, since it's not marked as internal. Safest to deprecate in 7.1 and remove in 8.0, I think?

@gmponos
Copy link
Member

gmponos commented Jan 20, 2020

@GrahamCampbell sorry my initial comment was confusing.. let me clarify..

this function: https://github.com/guzzle/guzzle/pull/2562/files#diff-8196fda03bd99e941e07599792a645a4R137

is not tagged.. why should it be deprecated?

@Nyholm
Copy link
Member

Nyholm commented Jun 13, 2020

Sorry for the long delay. Could you please rebase this PR?

@Nyholm
Copy link
Member

Nyholm commented Jun 27, 2020

Pleas rebase so I can merge.

@Nyholm
Copy link
Member

Nyholm commented Jun 27, 2020

It seams like this includes changes from #2561

@GrahamCampbell
Copy link
Member Author

Yes, because it depends on the other PR being merged first. Notice how 53c9ac5 changes a deprecation message from one of the functions.

@GrahamCampbell GrahamCampbell marked this pull request as draft June 27, 2020 09:59
@GrahamCampbell GrahamCampbell marked this pull request as ready for review June 27, 2020 10:41
@GrahamCampbell
Copy link
Member Author

Sorted this out now. :)

@GrahamCampbell GrahamCampbell mentioned this pull request Jun 27, 2020
Closed
Nyholm
Nyholm approved these changes Jun 27, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm merged commit 879a6c6 into guzzle:master Jun 27, 2020
@GrahamCampbell GrahamCampbell deleted the more-deprecate branch June 27, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GrahamCampbell @gmponos @Nyholm