[8.0] Convert static property to constant #2463
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is probably a good idea. But it's not that important for 7.0. I'd like to concentrate on the release. |
Yes I had it on 8.0.0 milestone. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 2 weeks if no further activity occurs. Thank you for your contributions. |
|
This needs a rebase. Also please dont change the phpstan-baseline. |
YasinAshorian
approved these changes
Oct 13, 2022
aznj
reviewed
May 14, 2023
| @@ -30,7 +30,7 @@ class SetCookie | |||
| public static function fromString(string $cookie): self | |||
| { | |||
| // Create the default return array | |||
| $data = self::$defaults; | |||
| $data = self::DEFAULTS; | |||
GrahamCampbell
changed the title
|
@gmponos Are you able to resolve the merge conflicts please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By converting the static property to constant I guess this will disallow overwritting.
Again I am not sure if this is something we want for v7 or v8 or even if we want it at all.