add support for DER and P12 certs (#2411)

[razvanphp]

https://curl.haxx.se/libcurl/c/CURLOPT_SSLCERTTYPE.html

This will fix #2411

[Nyholm]

I think this makes sense. Could you add a test for it?

Also, it needs a rebase.

[Nyholm]

Friendly ping

[razvanphp]

ok, I will try to do that.

[GrahamCampbell]

I think this could be added to the 7.3.0 milestone (for November??? release).

[maksimovic]

Any idea when this will make its way to the release? We rely on Guzzle and are in need of P12 cert support pretty urgently, so I'm checking in here to see what our options are. Thanks.

[Nyholm]

I need a test for this PR before we can review and merge it.
After merge we are usually pretty quick to release it.

We haven't heard from the author for about a year. @maksimovic feel free to open a new PR with this fix and a test. That will probably be the quickest way to get this released.

[Nyholm]

Ooops. @razvanphp answered a month ago.. What is the status? Do you need help from @maksimovic?

[razvanphp]

I'm on it 🙂 didn't work on the project that needed this for some time...

[razvanphp]

Rebased, tests added, thank you!

[Nyholm]

Thank you

@maksimovic Could you give this a review and make sure that it works?

[razvanphp]

@maksimovic ping :)

[maksimovic]

Unfortunately, we opted out of using Guzzle because we're using an older version it, but can't upgrade it quickly since it's the vital part of our stack and also includes bringing some other dependencies to a more recent version, which then have their dependencies requiring version bump, so it turned out to be way more work that we anticipated.

[razvanphp]

@Nyholm what do you think? can we merge this tho? I've already tested it in our application, also the tests are included in the PR.

[nuernbergerA]

Hey @Nyholm we need p12 support in our application too.

Is there still anything blocking this from being merged?

[Nyholm]

@nuernbergerA Have you tested this patch in your app? Does it work as expected?

[nuernbergerA]

@Nyholm yes it works.

But if there is any reason you want to reject the PR I'm fine to include the curl key.

'curl' => [
    CURLOPT_SSLCERTTYPE => 'P12',
],

[Nyholm]

No. I don't want to reject it. I want to be comfortable that merging this fixes the issue and does not break anything.

I'm not familiar with the feature but since many people request this, I encourage people to verify the patch and not only bump the thread.

[Nyholm]

Thank you