Collect appconnect_time in CurlFactory TransferStats #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice to merge this |
|
@1ma thanks! Can you please rebase your branch? |
|
Yup, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
For some historical reason the original implementation of
curl_getinfo($ch)did not include theappconect_timemetric and wasn't available until PHP 5.5.0, where it can be retrieved separatedly by passing theCURLINFO_APPCONNECT_TIMEconstant as the second parameter ofcurl_getinfo($ch, $opt).appconnect_timeis the time it takes cURL to negotiate the TLS handshake with the server after it establishes a TCP connection.This PR records
appconnect_timeinto the TransferStats::$handlerStats array, so it can be read and used inon_statscallables.References
https://www.php.net/manual/en/function.curl-getinfo.php#refsect1-function.curl-getinfo-changelog
https://curl.haxx.se/libcurl/c/CURLINFO_APPCONNECT_TIME.html
http://docs.guzzlephp.org/en/stable/request-options.html#on-stats