Use get_message_body_summary of PSR7 and require min 1.5 #2227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmponos
commented
Dec 3, 2018
gmponos
commented
Dec 3, 2018
This was referenced Dec 3, 2018
|
Looks like this is in direct conflict with #2272 |
|
Why? The function on the PSR-7 package has a parameter on how many chars to use https://github.com/guzzle/psr7/blob/master/src/functions.php#L853 after merging this the author of the other MR has to resolve conflicts... or it could be the other way around... |
Nyholm
requested changes
Oct 18, 2019
composer.json
Outdated
| @@ -24,7 +24,7 @@ | |||
| "php": ">=5.5", | |||
| "ext-json": "*", | |||
| "guzzlehttp/promises": "^1.0", | |||
| "guzzlehttp/psr7": "^1.4" | |||
| "guzzlehttp/psr7": "^1.5.2" | |||
There was a problem hiding this comment.
This change is not needed.
Please rebase your PR:
sagikazarmark
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.