Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MessageFactory for PHP 7.3 #2112

Merged
merged 1 commit into from Jul 31, 2018
Merged

Fix MessageFactory for PHP 7.3 #2112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions .travis.yml
View file
Open in desktop
Expand Up @@ -5,7 +5,10 @@ php:
- 5.5
- 5.6
- 7.0
- 7.1
- 7.2
- hhvm
- nightly

env:
global:
Expand All @@ -26,6 +29,7 @@ script: $TEST_COMMAND
matrix:
allow_failures:
- php: hhvm
- php: nightly
fast_finish: true
include:
- php: 5.4
Expand Down
8 changes: 4 additions & 4 deletions src/Message/MessageFactory.php
View file
Open in desktop
Expand Up @@ -194,7 +194,7 @@ protected function applyOptions(
case 'allow_redirects':

if ($value === false) {
continue;
continue 2;
}

if ($value === true) {
Expand All @@ -213,7 +213,7 @@ protected function applyOptions(
case 'decode_content':

if ($value === false) {
continue;
continue 2;
}

$config['decode_content'] = true;
Expand Down Expand Up @@ -251,7 +251,7 @@ protected function applyOptions(
case 'auth':

if (!$value) {
continue;
continue 2;
}

if (is_array($value)) {
Expand Down Expand Up @@ -354,7 +354,7 @@ protected function applyOptions(
if (isset($this->customOptions[$key])) {
$fn = $this->customOptions[$key];
$fn($request, $value);
continue;
continue 2;
}

throw new Iae("No method can handle the {$key} config key");
Expand Down