Fix bug parsing 0 epoch expiry times #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per guzzle#1952 expiry times specified as "Thu, 01 Jan 1970 00:00:00 GMT" should be treated as expired, but they weren't because 0 was implicitly casting to a bool in SetCookie::isExpired().
|
👍 |
|
Great patch, thanks a lot and sorry for the delay. |
This was referenced Mar 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #1952 expiry times
specified as
Thu, 01 Jan 1970 00:00:00 GMTshould be treated asexpired, but they weren't because 0 was implicitly casting to a bool in
SetCookie::isExpired().