Ignore zeroed timeout with StreamHandler to use PHP default instead #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using \GuzzleHttp\Client without cURL being installed falls back to the StreamHandler. As documented, guzzle uses a `timeout => 0` setting by default, if that setting isn't explicitly passed as option. This value is passed to the context of the stream, causing every request to fail instantly as `timeout => 0` has a different meaning for streams. Fixes #1487
This was referenced Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using \GuzzleHttp\Client without cURL being installed falls back to the
StreamHandler. As documented, guzzle uses a
timeout => 0setting bydefault, if that setting isn't explicitly passed as option. This value
is passed to the context of the stream, causing every request to fail
instantly as
timeout => 0has a different meaning for streams.Fixes #1487