Do not attempt to escape cookie values. #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @return string | ||
| */ | ||
| public static function getCookieValue($value) |
There was a problem hiding this comment.
Instead of removing this public method, let's mark it as deprecated, remove the rest of the docblock other than the @deprecated annotation, and have it just return the value as-is. That way anyone calling this directly wont break.
dvaeversted
force-pushed
the
noqoute-cookies
branch
from
f98aae5
to
1f3f070
Compare
|
Updated commit according to comments. |
Trust that the cookie value sent by the server is escaped accordingly, and do not attempt to escape the cookie by adding quotes around the value.
dvaeversted
force-pushed
the
noqoute-cookies
branch
from
1f3f070
to
9a6691f
Compare
|
thanks! |
mtdowling
added a commit
that referenced
this pull request
Feb 17, 2016
Do not attempt to escape cookie values.
|
I've spend two days debugging my app, goutte and guzzle till I found this as the root of my problem 😭 When is this going to be released? Thanks 😁 |
|
@carlosV2 : Released 20 hours ago |
|
@avindra thanks and thanks for reporting it :) |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trust that the cookie value sent by the server is escaped accordingly,
and do not attempt to escape the cookie by adding quotes around the value.
This is a pull request for: #1405
I can see others have run into the same issue: http://tricksty.com/coding/remove-double-quotes-from-guzzle-cookies