Changed type hinting from array to ArrayAccess. #1372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As you can see by the test failures in Travis, your proposed change is a breaking change. By changing it to \ArrayAccess, arrays will no longer work. I you are having trouble with how the Laravel IoC container works with this object, then I suggest wrapping it with a custom object. |
jeremeamia
added a commit
that referenced
this pull request
Jan 22, 2016
Allows an array or array-accessible object to be used as the history container for the history middleware.
|
Closing in favor of #1373 |
|
Thanks, that works great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the type hinting am not able to pass an ArrayObject as a container.
Passing an array is not possible for me, as i will have to pass it around by reference.
and laravel IOC while resolving wont pass the paraments by reference.
the solution i found is to make the container an object ie: ArrayObject, as it will be passed by reference.
But the type hinting was preventing me from doing so.