Fixed wrong parameter order in explode() (#2866)

guzzle · Mar 7, 2021 · da94ef2 · da94ef2
1 parent 2793fe2
commit da94ef2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/Utils.php b/src/Utils.php
@@ -232,7 +232,7 @@ public static function isHostInNoProxy(string $host, array $noProxyArray): bool
         // Strip port if present.
         if (\strpos($host, ':')) {
             /** @var string[] $hostParts will never be false because of the checks above */
-            $hostParts = \explode($host, ':', 2);
+            $hostParts = \explode(':', $host, 2);
             $host = $hostParts[0];
         }
 

diff --git a/tests/UtilsTest.php b/tests/UtilsTest.php
@@ -117,6 +117,7 @@ public function noProxyProvider()
         return [
             ['mit.edu', ['.mit.edu'], false],
             ['foo.mit.edu', ['.mit.edu'], true],
+            ['foo.mit.edu:123', ['.mit.edu'], true],
             ['mit.edu', ['mit.edu'], true],
             ['mit.edu', ['baz', 'mit.edu'], true],
             ['mit.edu', ['', '', 'mit.edu'], true],