Merge pull request #1999 from curtisdf/malformed-domain

Error with malformed domain that contains a "/" character
guzzle · Mar 26, 2018 · 6da464c · 6da464c
2 parents 8ffb1d2 + e6f837a
commit 6da464c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/Cookie/SetCookie.php b/src/Cookie/SetCookie.php
@@ -348,7 +348,7 @@ public function matchesDomain($domain)
             return false;
         }
 
-        return (bool) preg_match('/\.' . preg_quote($cookieDomain) . '$/', $domain);
+        return (bool) preg_match('/\.' . preg_quote($cookieDomain, '/') . '$/', $domain);
     }
 
     /**

diff --git a/tests/Cookie/SetCookieTest.php b/tests/Cookie/SetCookieTest.php
@@ -116,6 +116,9 @@ public function testMatchesDomain()
 
         $cookie->setDomain('.local');
         $this->assertTrue($cookie->matchesDomain('example.local'));
+
+        $cookie->setDomain('example.com/'); // malformed domain
+        $this->assertFalse($cookie->matchesDomain('example.com'));
     }
 
     public function pathMatchProvider()