refactor(cli): Migrate from alecthomas/kingpin to spf13/cobra. #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change migrates all of the current CLI code (and related tests) to now use cobra. All functionality should stay identical with the flags. The only changes present within the tests are the formatting of specific errors, and how they differ between kingpin/cobra. One potential breaking change that could impact users is that all `gunk help...` commands now print to stdout, even if invalid. This is not true for other errors, so it probably should not break any real world applications. This change can be linked back to spf13/cobra#1002.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change migrates all of the current CLI code (and related tests) to
now use cobra. All functionality should stay identical with the flags.
The only changes present within the tests are the formatting of specific
errors, and how they differ between kingpin/cobra.
One potential breaking change that could impact users is that all
gunk help...commands now print to stdout, even if invalid. This isnot true for other errors, so it probably should not break any real
world applications.
This change can be linked back to spf13/cobra#1002.