Remove some seemingly obsolete recipes #2497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gulp v4 supports this natively by combining `since` with `gulp.lastRun()`. https://gulpjs.com/docs/en/api/lastrun
gulp v4 supports this natively, as explained in the recipe itself, so there is no need for it.
This is a core feature, it's not necessary to explain it in a recipe.
gulp v4 supports this natively now, tasks can return a child process. https://gulpjs.com/docs/en/getting-started/async-completion#returning-a-child-process
The `cwd` option is described in the docs for `gulp.src`, and `--cwd` can be found when running `gulp --help`. Having this as a recipe seems unnecessary.
It should be very obvious that you can `require` functions from other files in `gulpfile.js` and export them as tasks, it seems unnecessary to use `gulp-hub`.
It seems too basic and obvious.
silvenon
force-pushed
the
remove-recipes
branch
from
c2dbbcb
to
004646d
Compare
|
@silvenon perfect! I agree with all these removals and their reasonings! I will "rebase and merge". Thank you for following the conventional commit pattern, too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the following recipes:
The explanations are in the commit messages.
This is of course very subjective and some removals may be too extreme. What do you think? This is in preparation for #2164. Also, does it make sense to still have Browserify recipes?