Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Detail creation of custom registries #2479

Merged
merged 4 commits into from Aug 24, 2020
Merged

Docs: Detail creation of custom registries #2479

merged 4 commits into from Aug 24, 2020

Conversation

pixeldesu
Copy link
Contributor

This PR picks up the "Creating custom registries" bullet point from #2256

While writing this, I found that in the undertaker README, registry() is partially explained already, but I felt that just copy-pasting wasn't enough and the document here is a bit more thorough on what's exactly required or happening.

I also decided to link to all of the PoC registries that have been created in the organization beforehand, so people have some more starting points.

@phated
Copy link
Member

phated commented Aug 16, 2020

@pixeldesu WOW! This is amazing!!! Thank you for adapting the undertaker README for the wider gulp audience.

I'm wondering if you could adapt https://github.com/gulpjs/undertaker#sharing-tasks and https://github.com/gulpjs/undertaker#sharing-functionalities for the audience as well? Those seem really important for explaining how you'd perform those use cases with a custom registry.

Once we get this landed, I'll restructure it into an "advanced" section for our website (which will be our first!).

@pixeldesu
Copy link
Contributor Author

@phated Thanks for the feedback, didn't really expect it to be this well received! 😄

I could definitely wrangle the two Undertaker sections into the document as well, I'm just thinking about a structure for that now.

Maybe a "Use Cases" section? I think the examples here are actually thorough enough, I would just adjust them to use Gulp/Gulp exports instead of Undertaker, of course.

So the final structure afterwards would be

Creating Custom Registries

  • Registry Structure (I guess I'll probably even drop the Registry here, it seems redundant, now looking at it)
  • Registration
  • Methods
  • Use Cases
  • Examples

@phated
Copy link
Member

phated commented Aug 16, 2020

Yeah, I think that is perfect actually!

What if the top 2 sections were flipped?

  1. Registration (maybe use one of the examples as the import)
  2. Creating a Registry (What do you think of this name?)
  3. Methods
  4. Use Cases
  5. Examples

One thing I just remembered is that there are "not implemented" references to custom registries in the gulp documentation, could you update those links as well? That would help me have a good diff of where the references are.

@pixeldesu
Copy link
Contributor Author

What if the top 2 sections were flipped?

Hmmm. Considering the topic is the creation of custom registries, first handling the structure, which is then registered makes a bit more sense in terms of order. I was conflicted about this myself, but registering already existing registries is already explained in the registry() docs pretty much.

One thing I just remembered is that there are "not implemented" references to custom registries in the gulp documentation, could you update those links as well? That would help me have a good diff of where the references are.

I'll try to look for those and adjust them as necessary!

@phated
Copy link
Member

phated commented Aug 16, 2020

Hmmm. Considering the topic is the creation of custom registries, first handling the structure, which is then registered makes a bit more sense in terms of order.

👍 Solid logic. I agree with your decision 😄

@pixeldesu
Copy link
Contributor Author

@phated done!

As mentioned, I took the examples as given, just adjusted them to be for Gulp specifically! Also, I only found a single reference to the page on the registry() API page itself and removed the reference, it should now be resolved over the front matter ID anyway.

If there's anything else, just mention it!

Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I committed some style changes and changed the location. Going to get this merged and fit in into the website.

@phated phated merged commit 93564bd into gulpjs:master Aug 24, 2020
@phated
Copy link
Member

phated commented Aug 24, 2020

Thanks for all the work here @pixeldesu! This has been a great help 😄

@phated
Copy link
Member

phated commented Aug 24, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants