Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on deprecated gulp-util #55

Merged
merged 2 commits into from
Jan 17, 2018
Merged

Drop dependency on deprecated gulp-util #55

merged 2 commits into from
Jan 17, 2018

Conversation

TheDancingCode
Copy link

Closes #54

Copy link
Member

@demurgos demurgos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tracker1 Could we have this merged and published?

@tracker1 tracker1 merged commit 5bafd98 into gulp-community:master Jan 17, 2018
@demurgos
Copy link
Member

Thanks!

@tracker1
Copy link
Member

@TheDancingCode Would you like to be added to the contributors in the package.json?

@demurgos If you'd like, I could add you as a contributor so you can push to the project.

@demurgos
Copy link
Member

demurgos commented Jan 17, 2018

I'll be upfront that being able to perform these sort of maintenance updates when there are some ecosystem-wide change would be good but I will most likely won't have time to deal with issues specific to this library (fixing CI, updating deps is fine, but not sure about issues regarding the features of the lib).
It may be helpful occasionally so if it's fine with you, you can add me.

@tracker1
Copy link
Member

tracker1 commented Jan 17, 2018

demurgos, you've been added...

after a merge...

npm version (patch|minor|major)
git push
git push --tags

travis should do the publish to npm... though it was a bit wonky yesterday.

@tracker1
Copy link
Member

I'm frankly not even using gulp anymore, mostly webpack and/or npm scripts for a few years, so I get what you're saying. I don't think there's really a need to add new features, most changes are because of API changes.

@demurgos
Copy link
Member

Ok, thanks for the invite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants