Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform pages using Next.js app router #2627

Merged
merged 12 commits into from Nov 7, 2023
Merged

Platform pages using Next.js app router #2627

merged 12 commits into from Nov 7, 2023

Conversation

abkfenris
Copy link
Member

@abkfenris abkfenris commented Oct 31, 2023

Working on getting the pages that display the map of platforms working with Next.js app router.

  • Routing and layout scaffolding
  • Providers
    • Prefetching react-query data and hydration
    • Redux for units
    • Redux for map location?
    • Google analytics listener
  • Navbar
  • Map
  • Index
    • Wagtail
    • Superlatives
  • Platform sidebar
  • Single chart
  • Wind chart
  • Current conditions
  • Forecasts
  • All observations table
  • Region pages
  • Update nav for new region pages
  • [?] Zoom map to region on change
  • Remove old routes and pages
  • Remove superlatives error and return null instead
  • Generate static params
    • Regions
    • Platforms
    • Platform/observation
    • Platform/forecast
  • Tests
    • Cypress
    • Storyshots
    • React test renderer

@abkfenris abkfenris changed the title Platform pages using Platform pages using Next.js app router Nov 2, 2023
Tests are all likely some kinds of broken, and I've intentionally broken the model viewer for now, but we've got a map, platforms, and region pages
Copy link

cypress bot commented Nov 2, 2023

28 failed tests on run #962 ↗︎

28 9 3 0 Flakiness 0

Details:

Fix build by disabling modeling related work for the moment
Project: neracoos-buoy-map-1 Commit: 170aaed079
Status: Failed Duration: 01:16 💡
Started: Nov 3, 2023 4:07 PM Ended: Nov 3, 2023 4:08 PM
Failed  Platform/44007_spec.js • 8 failed tests

View Output Video

Test Artifacts
Platfrom 44007 > Can get to from Home Page Test Replay Output Screenshots
Platfrom 44007 > Shows platform status Test Replay Output Screenshots
Platfrom 44007 > Shows current conditions Test Replay Output Screenshots
Platfrom 44007 > Shows wind plot Test Replay Output Screenshots
Platfrom 44007 > Shows wave forecast Test Replay Output Screenshots
Platfrom 44007 > Has More info menu Test Replay Output Screenshots
Platfrom 44007 > Updated recently Test Replay Output Screenshots
Platfrom 44007 > Can view all observations Test Replay Output Screenshots
Failed  Platform/a01_spec.js • 9 failed tests

View Output Video

Test Artifacts
Platform A01 > Will get redirected Test Replay Output Screenshots
Platform A01 > Shows platform status Test Replay Output Screenshots
Platform A01 > Shows current conditions Test Replay Output Screenshots
Platform A01 > Shows air temp plot Test Replay Output Screenshots
Platform A01 > Shows wind plot Test Replay Output Screenshots
Platform A01 > Shows wave forecast Test Replay Output Screenshots
Platform A01 > Has More info menu Test Replay Output Screenshots
Platform A01 > Updated recently Test Replay Output Screenshots
Platform A01 > Can view all observations Test Replay Output Screenshots
Failed  Platform/m01_spec.js • 7 failed tests

View Output Video

Test Artifacts
Platfrom M01 > Will get redirected Test Replay Output Screenshots
Platfrom M01 > Shows platform status Test Replay Output Screenshots
Platfrom M01 > Shows air temp plot Test Replay Output Screenshots
Platfrom M01 > Shows wave forecast Test Replay Output Screenshots
Platfrom M01 > Has More info menu Test Replay Output Screenshots
Platfrom M01 > Updated recently Test Replay Output Screenshots
Platfrom M01 > Can view all observations Test Replay Output Screenshots
Failed  Platform/mooring_location_regression_spec.js • 2 failed tests

View Output Video

Test Artifacts
Mooring location regressions > Finds the correct location for B01 Test Replay Output Screenshots
Mooring location regressions > Finds the correct location for I01 Test Replay Output Screenshots
Failed  Region/long_island_spec.js • 1 failed test

View Output Video

Test Artifacts
Region: Long Island > Shows only a subset of platforms Test Replay Output Screenshots

The first 5 failed specs are shown, see all 6 specs in Cypress Cloud.

Review all test suite changes for PR #2627 ↗︎

- Remove duplicate 500 story and page, and move image to app dir
- Mock usePathname hook for storyshots and Navbar tests
@abkfenris
Copy link
Member Author

Currently having issues with Cypress tests due to hydration, and we are not alone. It appears to be a bug deep within react. Some issues for reference:

@abkfenris
Copy link
Member Author

@abkfenris
Copy link
Member Author

@Adelle-Pitsas and my plan for now is to disable the Cypress tests until the linked issues are solved, and use the Cypress test scripts as instructions for manual testing.

@abkfenris abkfenris merged commit d0bfc10 into main Nov 7, 2023
6 of 7 checks passed
Copy link

sentry-io bot commented Nov 14, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ReferenceError: bbox is not defined bbox(app/(platformMap)/map.tsx) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants