Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Snyk GitHub action using CLI #356

Merged
merged 6 commits into from
Feb 10, 2022
Merged

Adds Snyk GitHub action using CLI #356

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3994bd1
Adds Snyk GitHub action using CLI
SHession Jan 18, 2022
ee285fe
Updates sbt-dependency-graph for more accurate results
SHession Jan 18, 2022
25ca116
Removes debug steps from Snyk workflow
SHession Jan 19, 2022
0bbf882
test reusable workflow
SHession Jan 19, 2022
141c645
test .github workflow
SHession Jan 19, 2022
2550c9c
Adds org to reusable workflow
SHession Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/snyk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: Snyk

on:
schedule:
- cron: "0 6 * * *"
push:
# branches:
# - main
workflow_dispatch:

jobs:
security:
uses: guardian/.github/.github/workflows/sbt-node-snyk.yml@add-generic-snyk-workflow
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no expert but I think maybe a nicer way of exposing this generic action would be to separate into its own repo and then create an example usage in a workflow in the .github repo that references the standalone action. Then the reference here can be a bit cleaner, something like guardian/snyk-generic-action@1.0.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good point, I would be open to that idea. I'm not sure if there is an important distinction between workflows and actions to be made. I think workflows may need to be referenced in this convoluted way.

with:
DEBUG: "true"
secrets:
SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }}
2 changes: 1 addition & 1 deletion project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.11")

addSbtPlugin("com.eed3si9n" % "sbt-buildinfo" % "0.9.0")

addSbtPlugin("net.virtual-void" % "sbt-dependency-graph" % "0.9.2")
addSbtPlugin("net.virtual-void" % "sbt-dependency-graph" % "0.10.0-RC1")