Add legends and secure checkout SVG to checkout #6002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +13 B (0%) Total Size: 1.98 MB ℹ️ View Unchanged
|
| @@ -695,8 +696,8 @@ function CheckoutComponent({ geoId }: Props) { | |||
| > | |||
| <Box cssOverrides={shorterBoxMargin}> | |||
| <BoxContents> | |||
| <div css={personalDetailsFieldGroupStyles(true)}> | |||
| <h2 css={personalDetailsHeader}>Your details</h2> | |||
| <fieldset css={fieldset}> | |||
There was a problem hiding this comment.
As this css is related to a single fieldset and not all, would its be worth giving it a longer name like fieldsetPersonalDetails?
There was a problem hiding this comment.
I've added this to payment fields too - but I am not sure we should as the CSS is using first-of-type, so I might try a refactor post-merge (so we can start demoing this).
paul-daniel-dempsey
approved these changes
May 14, 2024
@paul-daniel-dempsey it's because forms drive so much interactivity on the web. Always work looking at MDN for reference! |
…ric-checkout-design
|
Seen on PROD (merged by @jamesgorrie 10 minutes and 51 seconds ago)
Sentry Release: support-client-side, support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5722
fieldsetI know that the
1.,2.,n.won't work when we have delivery fields, I will reach out to Helene and see if there is a generic design solution to this.Worth avoiding whitedspace check in the diff.