Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Feast IAP acquisition support #5960

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Feast IAP acquisition support #5960

wants to merge 2 commits into from

Conversation

tjmw
Copy link
Member

@tjmw tjmw commented Apr 25, 2024

What are you doing in this PR?

Currently Feast IAPs are missing from the fact_acquisition_event table in the lake. The live apps do this by making requests from the device to the acquisitions API endpoint. For Feast we'd like to do this directly from the mobile-purchases estate, writing events directly to the event bus.

This PR starts adding support for this. So far we have:

  • A new product type for Feast IAPs
  • A cross account role for the mobile account to assume in order to write to the event bus

Trello Card

Why are you doing this?

How to test

How can we measure success?

Have we considered potential risks?

Accessibility test checklist

Screenshots

Copy link
Contributor

github-actions bot commented Apr 25, 2024

Size Change: 0 B

Total Size: 1.94 MB

ℹ️ View Unchanged
Filename Size
./public/compiled-assets/javascripts/[countryGroupId]/checkout.js 143 kB
./public/compiled-assets/javascripts/ausMomentMap.js 107 kB
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 217 kB
./public/compiled-assets/javascripts/downForMaintenancePage.js 68 kB
./public/compiled-assets/javascripts/error404Page.js 68 kB
./public/compiled-assets/javascripts/error500Page.js 67.9 kB
./public/compiled-assets/javascripts/favicons.js 616 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 168 kB
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 84.8 kB
./public/compiled-assets/javascripts/payPalErrorPage.js 66.5 kB
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B
./public/compiled-assets/javascripts/promotionTerms.js 71.2 kB
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 70.3 kB
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 124 kB
./public/compiled-assets/javascripts/supporterPlusLandingPage.js 284 kB
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 188 kB
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 85 kB
./public/compiled-assets/webpack/363.js 18.2 kB
./public/compiled-assets/webpack/385.js 81.8 kB
./public/compiled-assets/webpack/735.js 2 kB
./public/compiled-assets/webpack/775.js 18 kB
./public/compiled-assets/webpack/991.js 2.16 kB

compressed-size-action

The mobile-purchases codebase is going to be adding items to the event
bus when IAP acquisitions occur for Feast.
@tjmw tjmw marked this pull request as ready for review April 26, 2024 14:41
@tjmw tjmw changed the title Add Feast App to acquisition products Add Feast IAP acquisition support Apr 26, 2024
Copy link
Member

@rupertbates rupertbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants