Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preact rendered app #5797

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Preact rendered app #5797

wants to merge 2 commits into from

Conversation

jamesgorrie
Copy link
Contributor

@jamesgorrie jamesgorrie commented Mar 14, 2024

We'd like to run an integral subset of our E2E tests on: pull_request1.

To do this we need to run our app in a Containerfile. This PR is a spike to investigate what steps we might take to get there.

There are a few areas I've looked into.

Running a Node vs Scala server

I'm not sure we need to try and address this before getting the app into a Container.

Still writing this up

Config

We currently inject config on the window.guardian prop via twirl.

This
the server is injected by fetching from a server endpoint /api/config - and then injecting that on the page. This could be simplified in future as we now have server / client idempotency by it all being written in TS. [how we

Footnotes

  1. Citation needed

Copy link
Contributor

github-actions bot commented Mar 14, 2024

Size Change: +10 B (0%)

Total Size: 1.78 MB

ℹ️ View Unchanged
Filename Size Change
./public/compiled-assets/javascripts/ausMomentMap.js 107 kB 0 B
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B 0 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 216 kB 0 B
./public/compiled-assets/javascripts/downForMaintenancePage.js 67.7 kB 0 B
./public/compiled-assets/javascripts/error404Page.js 67.7 kB 0 B
./public/compiled-assets/javascripts/error500Page.js 67.6 kB 0 B
./public/compiled-assets/javascripts/favicons.js 616 B 0 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 168 kB 0 B
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 84.4 kB 0 B
./public/compiled-assets/javascripts/payPalErrorPage.js 66.2 kB 0 B
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B 0 B
./public/compiled-assets/javascripts/promotionTerms.js 70.9 kB 0 B
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 70 kB 0 B
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 124 kB 0 B
./public/compiled-assets/javascripts/supporterPlusLandingPage.js 277 kB +10 B (0%)
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B 0 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 185 kB 0 B
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 84.6 kB 0 B
./public/compiled-assets/webpack/385.js 81.8 kB 0 B
./public/compiled-assets/webpack/67.js 18.1 kB 0 B
./public/compiled-assets/webpack/735.js 2 kB 0 B
./public/compiled-assets/webpack/775.js 18 kB 0 B
./public/compiled-assets/webpack/991.js 2.16 kB 0 B

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant