Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to run an integral subset of our E2E tests
on: pull_request
1.To do this we need to run our app in a
Containerfile
. This PR is a spike to investigate what steps we might take to get there.There are a few areas I've looked into.
Running a Node vs Scala server
I'm not sure we need to try and address this before getting the app into a Container.
Still writing this up
Fastify
server that Preact server renders an equivalent of ourmain.scala.html
Config
We currently inject config on the
window.guardian
prop via twirl.This
the server is injected by fetching from a server endpoint
/api/config
- and then injecting that on the page. This could be simplified in future as we now have server / client idempotency by it all being written in TS. [how weFootnotes
Citation needed ↩