Bump sbt to 1.7.2 #115
Closed
Bump sbt to 1.7.2 #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathonherbert
force-pushed
the
jsh/bump-sbt
branch
from
df4a7ea
to
5434570
Compare
jonathonherbert
force-pushed
the
jsh/bump-sbt
branch
from
dc644ba
to
509d0b3
Compare
andrew-nowak
approved these changes
May 26, 2023
There was a problem hiding this comment.
👋🏽 Since #119, this repository is being built using GitHub Actions. Please rebase this branch against main to ensure it's built.
Or close the PR if it's no longer needed.
|
superceded in 91836c9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Bumps sbt to 1.7.2 – >1.4.x is necessary for the project to compile on M1 machines. I've also bumped the relevant Play libs, as Play 2.8 has problems with later versions of sbt that are fixed in >2.8.8.
Why not latest (1.8.2 at time of writing)?
Bumping to latest pulls in two different major versions of scala-xml. There are workarounds that IIUC involve handwaving this conflict, but given that this is an important dependency that touches many projects, perhaps that's best avoided.
The latest version of Twirl uses scala-xml 2.x, which I think will be coming in Play 2.9, so I think we'll have to wait for Play 2.9 to resolve this without that workaround. If others would prefer us to bump sbt rather than wait, we can use the workaround above.