Skip to content
This repository has been archived by the owner on Mar 3, 2022. It is now read-only.

7.0.0 : Downgrade to @guardian/types v3.0.0 #240

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

faresite
Copy link

@faresite faresite commented Mar 10, 2021

What does this change?

  • Downgrades @guardian/types from v4.0.0 to v3.0.0
  • Updates vulnerable packages
  • Moves dependencies to devDependencies and peerDependencies

Currently discussion-rendering and atoms-rendering are still on @guardian/types v3.0.0, which would result in conflicting versions of types for our apps-rendering emotion 11 update.

This should help us move to emotion 11 on apps-rendering without getting blocked by discussion-rendering or atoms-rendering being behind on types for the time being. But it will need to happen soon enough to unblock other work necessary for apps-rendering (for example the Letter template on editions-rendering).

Comment on lines -6 to 7
"dependencies": {
"peerDependencies": {
"@emotion/babel-plugin": "^11.1.2",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JamieB-gu This is more inline with how atoms-rendering and discussion-rendering do it. It avoids the problem we had when we'd have two conflicting versions installed in the host app because peerDependencies was specifying a different version than dependencies. Adding it to devDependencies too allows us to build the project locally and run storybook. I'm not aware of downsides as I haven't encountered any so maybe there's a reason it was in dependencies in the first place.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant