Use setup-java support for sbt-caching
#3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyley
commented
Dec 28, 2022
Comment on lines
4
to
-10
| pull_request: | ||
| # Triggering CI on default branch improves caching | ||
| # see https://docs.github.com/en/free-pro-team@latest/actions/guides/caching-dependencies-to-speed-up-workflows#restrictions-for-accessing-a-cache | ||
| push: | ||
| branches: | ||
| - main | ||
|
|
||
| env: | ||
| isPrFromForkedRepo: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.repo.owner.login != 'guardian' }} |
There was a problem hiding this comment.
It's safe to get rid of the isPrFromForkedRepo condition - as you can see in this test PR by an external account, it says "1 workflow awaiting approval" & "First-time contributors need a maintainer to approve running workflows." - GitHub has had this safeguard in place since April 2021.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/actions/setup-java#caching-sbt-dependencies
See guardian/prout#75 for another example of this.