Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require projects specify Java version in .tool-versions so we build with that version, use Java 21 LTS elsewhere #31

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Require projects specify Java version in .tool-versions so we build with that version, use Java 21 LTS elsewhere #31

wants to merge 1 commit into from

Commits on Mar 14, 2024

  1. Use Java 21 LTS 

    John Duffell has reported improved speed from Java 21 LTS:

https://chat.google.com/room/AAAAag0I08g/Nvinl3aN_cU/

...and Mariot has confirmed that we should be encouraging people to move to Java 21.

In `gha-scala-library-release-workflow` we always use the same version of Java to _compile_ the project, regardless of the repo, because we've not yet encountered a need to configure the Java on a pre-repo basis. However, we do recommend that repos specify the `-release` flag in their `build.sbt` `scalacOptions`, which specifies the minimum release of Java that should be supported in the resulting artifacts - we still have some systems runinng on Java 8, so unfortunately they need `-release:8`

https://docs.scala-lang.org/overviews/jdk-compatibility/overview.html#jdk-21-compatibility-notes
    @rtyley
    rtyley committed Mar 14, 2024
    Copy the full SHA
    5a688f1 View commit details
    Browse the repository at this point in the history